Presto connections too many

Luiggi · July 17, 2021, 11:37am

Hi, we're going to launch a new Presto driver in the next version. Stay tuned

utopian · July 18, 2021, 11:44am

Today I've modified code and compiled it successfully, and it's tested to be possible.
The specific modifications are as follows:
Modules/drivers/presto/src/metabase/driver/presto.clj
Add Comment Line 234
;; (Execute-query-for-sync details sql-args)

rubenssoto · July 19, 2021, 3:13pm

@Luiggi this driver intends to solve this problem?

Thank you

rubenssoto · July 19, 2021, 3:13pm

Hello @utopian

With behavior do you want to achieve with this change?

thank you

Luiggi · July 19, 2021, 3:21pm

the new driver intends to solve many problems:

it will be more efficient as it uses JDBC
it will be configurable, so you can pass parameters and tweak config settings
it will allow developers to do more things internally with Metabase

rubenssoto · July 19, 2021, 5:34pm

Its an open source project, so, I dont like to ask for ETA, im sorry for that, but only to help me with my roadmap, do you have any idea when this new driver will be done?

Thank you so much

Luiggi · July 20, 2021, 2:27am

we plan to ship it soon, probably next major version (v41)

rubenssoto · July 21, 2021, 6:20pm

Hello @utopian

Did your tests work?

Do you have an idea to make a PR or a fork?

Thank you

utopian · July 22, 2021, 6:08am

It has passed the test and is feasible.
But I will not submit pr

rubenssoto · July 25, 2021, 12:50am

Hi Luiggi, how are you?

I saw this PR today:

How could I test the new presto driver?

If is use this image
https://hub.docker.com/r/metabase/metabase
with latest tag is it possible?

Thank you so much

Luiggi · July 25, 2021, 12:57am

Hi @rubenssoto, you should be able to test it by running "docker run -it -p 3000:3000 metabase/metabase-head"

the metabase-head image is the one that has everything in the main branch (watch out as it's not a release branch)

rubenssoto · July 25, 2021, 12:59am

Thank you for your answer, and after that is it the same presto source option or I have to choose a different one?

Luiggi · July 25, 2021, 1:07am

I haven't tested it yet, but I'm mostly sure that you'll have to do the switch from current driver to the JDBC one, but I'm not sure, so it would be great if you test it

rubenssoto · July 25, 2021, 1:15am

When I choose presto, metabase show me that is the new driver....

I tired to connect, but I got some errors:

2021-07-25 01:11:40,339 ERROR api.database :: Não posso conectar ao banco de dados
java.lang.Exception: Unrecognized connection property 'engine'

Do I have to open an issue on github?

Luiggi · July 25, 2021, 1:21am

Yes please, thanks so much for testing this

rubenssoto · July 25, 2021, 1:26am

No problem...

thank you