Site URL Keeps Changing to EC2 Host's IP Address

LLL · November 20, 2020, 6:26pm

@flamber - Sorry for dropping off and going AWOL. I believe I have found a bug in setting.clj regarding the priority of the Environment variables.

While on the website it states the following:

Many settings in Metabase can be viewed and modified in the Admin Panel, or set via environment variables. The environment variables always take precedence.

This has not been my experience with all environment variables. As such I dug in deeper and came across these lines in setting.clj which were updated around 6mo ago. The post which I had originally referenced above regarding #9764 was for release v0.32.6, and perhaps the PR #12541 accidentally broke the logic as the code changed.

github.com

metabase/metabase/blob/master/src/metabase/models/setting.clj#L179-L193


      
               :key key
               :value value}))
          
          (defmethod serdes/load-find-local "Setting" [[{:keys [id]}]]
            (get-value-of-type :string (keyword id)))
          
          (defmethod serdes/load-one! "Setting" [{:keys [key value]} _]
            (set-value-of-type! :string key value))
          
          (def ^:private Type
            (s/pred (fn [a-type]
                      (contains? (set (keys (methods get-value-of-type))) a-type))
                    "Valid Setting :type"))
          
          (def ^:private Visibility

When I flip the order of (db-or-cache-value setting-definition-or-name) and (env-var-value setting-definition-or-name) such that (env-var-value setting-definition-or-name) is first, the env variables I pass through are set as expected when viewing the Admin settings and then upon restarting of Metabase and not passing the env var, the variable(s) can be set (as anticipated).

That said, when passing MB_SITE_URL, the field is empty and shows the "default" empty string of "foo". I was expecting it to state "Using MB_SITE_URL", similar to #9764 and as it does for the Site Name setting. Picture attached below for additional context.