"Is empty" vs "Is not empty" mismatch in v0.45.2.1

[wj4]

Just updated to v0.45.2.1

Selecting the "Is empty" filter on the notebook builder applies the "Is not empty" filter.

The opposite is true as well. Both shown below

[jacob]

@wj4, can you reproduce this using a question built on the Sample Database? Or does it only happen with some tables/databases?

[wj4]

Sorry - perhaps a bit light on the details.

"Deleted At" in the screenshot above is a data field. This issue so far only seems to manifest when filtering on date fields.

I was able to replicate in sample database with a filter on people.created_at

[jacob]

Thanks for the additional information!

An issue exists mentioning this:

• Filtering of `is empty` and `is not empty` is confusing because they are under Exclude, which reverses meaning · Issue #26771 · metabase/metabase · GitHub

Essentially, it is getting reversed because it is in the "Exclude" clause which basically reverses whatever you set.

So if you exclude "is empty", then it only show the not empties, vs if you exclude "is not empty", then it would only show the empties.

[wj4]

I agree that the double negative is confusing on first glance. Maybe worth moving isempty/isnull type operations to a submenu for "Boolean Operations" or just add a section in the top level dropdown menu that already exists. These operations are already very commonly used.

Something like this is what I have in mind: