Would be useful to align the row count selection limit with the number of series a graph can use

jwag59 · February 9, 2018, 8:37am

After running a query that includes more than 20 series it is not possible to graph these. There is a limitation of the most graph types whereby they do not support data with more than 20 series.
In this case I decided I would limit the query to 20 returned results. This way I could use the query to show the top 20 results.
However in the row limit selection for a query we can only choose between “None, 10, 25, 100, 1000”.

Thus at best I can only select 10 to get the top 10 results. It would be great if we could either have a selection option for 20, or an input field which we can enter the exact number of results to return or if graphs could be extended to allow 25 series instead of 20.
In this way we could select a row limit that exactly matches the series limits of graphs and then everything is aligned nicely.

jornh · February 9, 2018, 11:06pm

So if there was a 20 in the LimitWidget:

github.com

metabase/metabase/blob/17b773df7c3b7b879dad9fe94ddfbff801b88217/frontend/src/metabase/query_builder/components/LimitWidget.jsx#L14


import { t } from 'c-3po';


export default class LimitWidget extends Component {


static propTypes = {
    limit: PropTypes.number,
    onChange: PropTypes.func.isRequired,
};


static defaultProps = {
    options: [undefined, 1, 10, 25, 100, 1000]
};


render() {
    return (
        <ul className="Button-group Button-group--blue">
            {this.props.options.map(count =>
                <li key={count || "None"} className={cx("Button", { "Button--active":  count === this.props.limit })} onClick={() => this.props.onChange(count)}>
                    {count || t`None`}
                </li>
            )}